Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YouTube] Add uploaderUrl and uploaderVerified to PlaylistInfoItem. #959

Merged
merged 2 commits into from
Oct 31, 2022
Merged

[YouTube] Add uploaderUrl and uploaderVerified to PlaylistInfoItem. #959

merged 2 commits into from
Oct 31, 2022

Conversation

FireMasterK
Copy link
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Note: There are no tests for this anywhere, so I haven't added any

@FireMasterK FireMasterK changed the title Add uploaderUrl and verified to PlaylistInfoItem. Add uploaderUrl and uploaderVerified to PlaylistInfoItem. Oct 29, 2022
@FireMasterK FireMasterK force-pushed the playlist-info-item-uploader branch 3 times, most recently from a3f7046 to 8aeba78 Compare October 29, 2022 22:01
@FireMasterK FireMasterK marked this pull request as draft October 29, 2022 22:11
@FireMasterK FireMasterK marked this pull request as ready for review October 29, 2022 22:21
TobiGr
TobiGr reviewed Oct 30, 2022
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just a minor note.
What about the other services?

extractor/src/main/java/org/schabi/newpipe/extractor/playlist/PlaylistInfoItem.java Show resolved Hide resolved
@TobiGr TobiGr added enhancement youtube service, https://www.youtube.com/ multiservice labels Oct 30, 2022
@FireMasterK
Copy link
Member Author

What about the other services?

I don't have the time or patience to implement them, sorry. I implemented this for Piped (where this PR is already deployed), where YouTube is the only used service.

@TobiGr TobiGr merged commit eb40bb8 into TeamNewPipe:dev Oct 31, 2022
@TobiGr TobiGr mentioned this pull request Oct 31, 2022
Closed
@TobiGr TobiGr changed the title Add uploaderUrl and uploaderVerified to PlaylistInfoItem. [YouTube] Add uploaderUrl and uploaderVerified to PlaylistInfoItem. Oct 31, 2022
This was referenced Nov 4, 2022
Merged
Closed
@FireMasterK FireMasterK deleted the playlist-info-item-uploader branch June 2, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
enhancement multiservice youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FireMasterK @TobiGr