Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block wrong nullable/nonnull imports in Checkstyle #989

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Block wrong nullable/nonnull imports in Checkstyle #989

merged 1 commit into from
Nov 28, 2022

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Nov 28, 2022 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Same as TeamNewPipe/NewPipe#9474, but here the Android annotation is forbidden and instead the javax is allowed. @TobiGr

@Stypox Stypox mentioned this pull request Nov 28, 2022
Merged
5 tasks
@TobiGr TobiGr merged commit 40f1ec4 into TeamNewPipe:dev Nov 28, 2022
@AudricV
Copy link
Member

AudricV commented Nov 28, 2022

Could you forbid the edu ones too or not?

@Stypox
Copy link
Member Author

Stypox commented Nov 28, 2022

Which ones are those? Android Studio wouldn't suggest them to me.

@AudricV AudricV changed the title Block wrong nullable/nonnull imports in checkstyle Block wrong nullable/nonnull imports in Checkstyle Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stypox @AudricV @TobiGr