Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PeerTube] Report Exceptions thrown while getting a stream's subtitles #994

Merged
merged 1 commit into from
Dec 31, 2022
Merged

[PeerTube] Report Exceptions thrown while getting a stream's subtitles #994

merged 1 commit into from
Dec 31, 2022

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Dec 3, 2022

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@TobiGr TobiGr added peertube service codequality Improvements to the codebase to improve the code quality labels Dec 3, 2022
Stypox
Stypox approved these changes Dec 31, 2022
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Stypox Stypox merged commit 95cc6ae into dev Dec 31, 2022
@opusforlife2 opusforlife2 deleted the fix/peertube-subtitles-exception branch December 31, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality peertube service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TobiGr @Stypox