Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(knapsack): fix the typo in nav-list-item url #2173

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

bsahitya
Copy link
Collaborator

Description

Fixed the typo in the url to Navigation List Item. Changed naviigation-list-item to navigation-list-item

What's included?

  • Changed pattern ID wherever applicable
  • Renaming relevant demo and spec files

Test Steps

  • npx nx run knapsack:start
  • Navigate to components -> List -> Navigation list item
  • Check the url in the browser

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker
Screenshot 2024-06-12 at 2 59 28 PM

@owilliams320 owilliams320 merged commit c411c63 into main Jun 14, 2024
6 checks passed
@owilliams320 owilliams320 deleted the docs/knapsack-nav-list-item branch June 14, 2024 13:11
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 8.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants