Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1: remove Message #239

Merged
merged 12 commits into from
May 30, 2016
Merged

V1: remove Message #239

merged 12 commits into from
May 30, 2016

Conversation

hypesystem
Copy link
Collaborator

This PR removes the Message abstraction, and moves validation of fields to the Sender.

It also allows for a new and nicer instantiation syntax:

var gcm = require("node-gcm")("<API KEY>");

gcm.send(...);

It also removes the mapping of property names we used to have. For example, the field collapseKey is now simply called collapse_key, just as it is on the FCM serverside. This reduces code complexity significantly.

@eladnava
Copy link
Collaborator

eladnava commented May 29, 2016

@hypesystem Excellent! Well done! 👍 💯

You rock. Let's merge. =)

@hypesystem
Copy link
Collaborator Author

@eladnava Thanks 😄 feel free to merge, if you think it looks good.

@eladnava eladnava merged commit 201f37b into v1 May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants