Merge pull request #18 from WaffleLapkin/calm_down_dont_panicb

Remove `.expect` from git code to prevent panics

CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [unreleased]
 
+## 0.1.9
+
+### Fixed
+
+- Panics on failed git pull (remove `.expect`s)
+
 ## 0.1.8
 
 ### Changed

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "crate_upd_bot"
-version = "0.1.8"
+version = "0.1.9"
 authors = ["Waffle <waffle.lapkin@gmail.com>"]
 edition = "2018"
 

src/main.rs

@@ -87,7 +87,11 @@ async fn main() {
         std::thread::spawn(move || {
             'outer: loop {
                 log::info!("start pulling updates");
-                pull(&repo, tx.clone()).expect("pull failed");
+
+                if let Err(err) = pull(&repo, tx.clone()) {
+                    log::error!("couldn't pull new crate version from the index: {}", err)
+                }
+
                 log::info!("pulling updates finished");
 
                 // delay for `config.pull_delay` (default 5 min)
@@ -159,10 +163,7 @@ fn pull(
     ch: Sender<(Crate, ActionKind, oneshot::Sender<Infallible>)>,
 ) -> Result<(), git2::Error> {
     // fetch changes from remote index
-    repo.find_remote("origin")
-        .expect("couldn't find 'origin' remote")
-        .fetch(&["master"], None, None)
-        .expect("couldn't fetch new version of the index");
+    repo.find_remote("origin")?.fetch(&["master"], None, None)?;
 
     // Collect all commits in the range `HEAD~1..FETCH_HEAD` (i.e. one before
     // currently checked out to the last fetched)