Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Clio when cache has error #1354

Open
cindyyan317 opened this issue Apr 12, 2024 · 2 comments
Open

Stop Clio when cache has error #1354

cindyyan317 opened this issue Apr 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working on hold For issues that currently wait on other issues
Milestone

Comments

@cindyyan317
Copy link
Collaborator

cindyyan317 commented Apr 12, 2024

If successor table contains incorrect data:

  1. contains deleted object in list
  2. does not contain existing object in list

We should detect this ASAP and act before wrong data gets written to the DB.

For case 1, we can detect error here.

We shall stop Clio or disable cache to avoid writing more wrong data to successor table.

For case 2, we need shamap library to detect the corruption.

@cindyyan317 cindyyan317 added the bug Something isn't working label Apr 12, 2024
@godexsoft godexsoft self-assigned this Apr 18, 2024
godexsoft added a commit that referenced this issue Apr 24, 2024
@kennyzlei
Copy link
Collaborator

kennyzlei commented Jun 3, 2024

After we have shamap library in libxrpl then we can work on addressing case 2. @cindyyan317 can you create a github issue on rippled side for the shamap library in libxrpl? 🙏

@kennyzlei kennyzlei added the on hold For issues that currently wait on other issues label Jun 3, 2024
@cindyyan317
Copy link
Collaborator Author

Feature requested: XRPLF/rippled#5038

kuznetsss pushed a commit that referenced this issue Jun 18, 2024
@kuznetsss kuznetsss added this to the Future milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working on hold For issues that currently wait on other issues
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants