chore: replaced friend for unit-test with mock #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlntb
changed the title
seelabs
reviewed
Jun 25, 2024
|
|
||
| // Make a dummy Nickname ledger entry to trigger an invalid ledger entry error. | ||
| Keylet nickname = {static_cast<LedgerEntryType>(0x006e), sha512Half('n', A1, (*sle)[sfSequence] + 2)}; | ||
| auto sleNew = std::reinterpret_pointer_cast<STLedgerEntry>(std::make_shared<STLedgerEntryMock>(nickname)); |
There was a problem hiding this comment.
Nice idea! I'm honestly not sure if this is UB or not (I suspect it is, but I'd also need to look at what the rules are for type punning).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving unit-test that have to access class internals
Context of Change
Replacing friend relationship between tested class (STLedgerEntry) and unit-test (Invariants_test) in favour of using mock. The change has no functional impact.
Type of Change
API Impact