Condition and fulfillment in escrow #698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckeshava
commented
Mar 22, 2024
| from typing import Dict, Optional, TypedDict | ||
|
|
||
| # CK: TODO Find a py.typed or library stub for cryptoconditions | ||
| from cryptoconditions import PreimageSha256 # type: ignore |
There was a problem hiding this comment.
Please let me know if you have any ideas to get mypy to work with a cryptographic library
ckeshava
commented
Mar 22, 2024
| cancel_after=datetime_to_ripple_time(datetime.now()) + 100, | ||
| ) | ||
|
|
||
| create_escrow_response = submit_and_wait(create_tx, client, wallet1) |
There was a problem hiding this comment.
I have empirically observed that the generated cryptographic condition always begins with A0258020... and ends with ...810120. I don't have statistical numbers to prove my point, but the outputs from this library do not appear random, despite varying secret inputs.
… into conditionalEscrow
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Provide utility functions to generate cryptographic condition and fulfillment for conditional escrows.
Type of Change
Did you update CHANGELOG.md?
Test Plan
Included unit test and snippet test to validate the working of
generate_crypto_conditionsfunction.This work was inspired by the PR by author and also the XRPL tutorials
Many thanks to both these sources.