Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated full parameter from ledger request model #722

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kennyzlei
Copy link

@kennyzlei kennyzlei commented Jul 4, 2024

High Level Overview of Change

Remove deprecated full parameter from ledger request model

Context of Change

In the ledger API, the full request parameter has been deprecated for quite awhile now. As of Clio 2.2.0 with this particular commit XRPLF/clio#1360, this API will return a request error if you provide that parameter. This change removes this parameter from the ledger request model. This change would not impact lib users as this using this parameter or setting it to true instead of default false previously would not have been used by rippled or Clio

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Existing integration tests should continue to pass and manual testing of ledger API with xrpl-py against Clio 2.2.0 should succeed

@kennyzlei kennyzlei changed the title Remove deprecated full parameter from ledger request model Remove deprecated full parameter from ledger request model Jul 4, 2024
@mvadari
Copy link
Collaborator

mvadari commented Jul 5, 2024

Please update the changelog.

@kennyzlei
Copy link
Author

@mvadari updated the changelog! thanks for the reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants