fix: declare Channel explicitly
#657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukusuket
changed the title
Channel explicitly
YamatoSecurity
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
@fukusuket Thanks for fixing these! I am not sure why I wrote them this way... 馃槄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Fixed a rule where
Channelwas not specified.When implementing Yamato-Security/hayabusa#1317 , the
Channelmust be specified explicitly.Test
I confirmed that there is no difference in the number of detections before and after the modification as shown below.
after:
https://github.com/Yamato-Security/hayabusa-rules/actions/runs/8871225497/job/24353898756#step:5:4856
before:
https://github.com/Yamato-Security/hayabusa-rules/actions/runs/8871253258/job/24353962845#step:5:4856
I would appreciate it if you could review when you have time馃檹