Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Bugs in Social Links in Multiple HTML Files and Respective style.css File #658

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NarendraKoya999
Copy link
Contributor

Related Issue

Proposed Changes

  • Added and Modified title Text(tooltip) on Telegram.
  • Modified class names related to Both Discord and YouTube Social Icons .
  • These above 2 Social Icon Classes changes in style.css File also.

Additional Info

- I cross check everything . If any Mistakes in my Changes Done, Please suggest to Me

Checklist

  • βœ… My code follows the code style of this project.
  • πŸ“ My change requires a change to the documentation.
  • πŸŽ€ I have updated the documentation accordingly.
  • 🌟 ed the repo
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1 Screenshot #2
Title goes here Title goes here
Image goes here Image goes here

@netlify
Copy link

netlify bot commented Jul 31, 2023

βœ… Deploy Preview for codesetgo ready!

Name Link
πŸ”¨ Latest commit f52d82f
πŸ” Latest deploy log https://app.netlify.com/sites/codesetgo/deploys/64c7cec50e27fe00094393fd
😎 Deploy Preview https://deploy-preview-658--codesetgo.netlify.app/contributer
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NarendraKoya999
Copy link
Contributor Author

Hi @agamjotsingh18 . Please Review on this PR as soon as Possible. When Pull Request is Done, Merge Conflicts Happened. I resolved That Conflicts Also.

@agamjotsingh18
Copy link
Owner

Hey, contributors page has some issues in mobile view

@NarendraKoya999
Copy link
Contributor Author

Hey, contributors page has some issues in mobile view

Ok @agamjotsingh18 .Can you Provide Screenshot? . I need some Clarity?

@agamjotsingh18
Copy link
Owner

Screenshot_2023-08-02-11-07-48-59_40deb401b9ffe8e1df2f1cc5ba480b12

@NarendraKoya999
Copy link
Contributor Author

Hi @agamjotsingh18 . This is not affected only basis on My Code Changes. May be other CSS Conflicts affects on My Issue.
I cross check everything in yesterday also.

@NarendraKoya999
Copy link
Contributor Author

Hi @agamjotsingh18 . Any Updates about this PR?

@agamjotsingh18
Copy link
Owner

Hi @agamjotsingh18 . Any Updates about this PR?

I can't merge PR with issues, you can fetch latest code it might work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants