Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: The visualizer needs more sorting algorithms #3

Open
3 tasks done
alesbe opened this issue Apr 20, 2022 · 6 comments
Open
3 tasks done

[FEAT]: The visualizer needs more sorting algorithms #3

alesbe opened this issue Apr 20, 2022 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alesbe
Copy link
Owner

alesbe commented Apr 20, 2022

Describe your problem:

Right now there is only 3 sorting algorithms, would be so cool to add more!

Steps to reproduce:

None

Possible fix (optional):

Add new sorting algorithms (how to add new algorithms)

OS

  • Windows
  • Mac OS
  • Linux
@alesbe alesbe added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 20, 2022
@alesbe alesbe self-assigned this Apr 22, 2022
@ariajanke
Copy link
Contributor

Hello,

Hope this is not too out of place. This looks like something I can contribute to. I've been looking for a first open source project. I'm familiar with SFML and C++. I'd like to take a crack at adding quicksort. (If you'd like.) c:

@alesbe
Copy link
Owner Author

alesbe commented May 13, 2022

Sure! I never had contributors to any project so it's a new experience for me too, I did this small wiki page with some info, let me know if you have any issue with the code, Im going to add some more info to the wiki page :)

@alesbe alesbe pinned this issue May 13, 2022
@alesbe alesbe removed their assignment May 13, 2022
alesbe added a commit that referenced this issue May 13, 2022
Added quicksort for #3, and a fix for #2
@alesbe alesbe changed the title The visualizer needs more sorting algorithms [FEAT]: The visualizer needs more sorting algorithms May 27, 2022
This was referenced Jun 3, 2022
@ariajanke
Copy link
Contributor

Think I may add merge sort later here. Give using the new branches a go. c:

@alesbe
Copy link
Owner Author

alesbe commented Jun 5, 2022

Awesome! Also, the algorithm functions will change a little bit (see #15), you can wait for the changes to be implemented because it's a relatively big change, or just make sure to pull the changes before doing the PR to prevent merge conflicts! :)

Edit: The changes has been implemented! #24

@Blargian
Copy link
Contributor

Any sorting algorithms that haven't been added yet that I could contribute to?

@alesbe
Copy link
Owner Author

alesbe commented Dec 18, 2022

@Blargian sure, thanks for your interest!

Here is a guide on how to add a new sorting algorithm.

These are the algorithms currently implemented:

  • Bubble sort
  • Selection sort
  • Insertion sort
  • Quick sort
  • Cocktail shaker sort
  • Bogo sort

Maybe the code needs a bit of refactoring in some areas, if you need more info just let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants