Adding draft of Ethereum Signed Transactions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Nov 9, 2022
ghost
commented
- Draft of Ethereum Signed Transactions #1
ghost
linked an issue
ghost
commented
Dec 19, 2022
|
|
||
| #### Logic | ||
|
|
||
| This should be implemented in the `crypto` package in the file `secp.go` line 65 as try/catch logic incase the traditional signature verification fails, we can check for this type of signature. |
There was a problem hiding this comment.
Should permalink this as line numbers change.
| digestHash := Hasher(ethMsg) | ||
| signature := s.Sign(digestHash) | ||
| v := new(Secp256k1Validator) | ||
| pubk, err := v.Validate(ethMsg, signature) |
|
|
||
| #### Alternative Solutions | ||
|
|
||
| Creating our own browser plugin wallet is a possibility, but it would be a lot of work and would require a lot of testing. |
There was a problem hiding this comment.
I recall seeing metamask having some kind of alternative plugin model or something here, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.