Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new reviewer): 'Hide system bars', 'Ignore display cutout' and 'Hide answer buttons' #16677

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BrayanDSO
Copy link
Member

@BrayanDSO BrayanDSO commented Jun 30, 2024

Approach

In the commits

How Has This Been Tested?

Emulator 34 and in my phone (Galaxy S23, Android 14):

Hide all bars + ignore cutout

ignore+both

Hide status bar + ignore cutout

Status

Hide status bar

status bar

Hide navigation bar

nav

Hide answer buttons

all hidden

no buttons

Learning (optional, can help others)

https://developer.android.com/develop/ui/views/layout/immersive

https://developer.android.com/develop/ui/views/layout/edge-to-edge#cutout-insets

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Contributor

Message to maintainers, this PR contains strings changes.

  1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
  2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

@BrayanDSO BrayanDSO force-pushed the rev_fullscreen branch 4 times, most recently from 168f7a5 to 9c3f308 Compare June 30, 2024 16:45
@BrayanDSO BrayanDSO changed the title feat(new reviewer): Hide system bars and Ignore display cutout feat(new reviewer): Hide system bars, Ignore display cutout and Hide answer buttons Jun 30, 2024
@BrayanDSO BrayanDSO changed the title feat(new reviewer): Hide system bars, Ignore display cutout and Hide answer buttons feat(new reviewer): 'Hide system bars', 'Ignore display cutout' and 'Hide answer buttons' Jun 30, 2024
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine, thanks!

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Second Approval Has one approval, one more approval to merge Strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants