Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update GitHub actions to their latest versions #602

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

SirGitsalot
Copy link
Collaborator

We're not using any new features from these actions, but the old versions are built on deprecated NodeJS releases.

@SirGitsalot
Copy link
Collaborator Author

With this PR the role tests are not only running* they're actually passing. The full integration test suite is not yet passing, but that looks like it's going to require some changes to the module itself (so not in this PR). The sanity integration test passes the actual tests, but fails on a linter check on the post-test cleanup shell script ¯\(ツ)

*The role tests never actually ran in our GitHub actions(!) The reason they "passed" before is that the test runner uses a glob pattern (molecule/*/molecule.yml) to find its tests. When run at the root of the GitHub action working directory that glob doesn't match anything. The reason the tests started failing recently is that molecule (the aforementioned test runner) was updated to fail if it didn't find any tests.

@SirGitsalot SirGitsalot merged commit 4927c06 into master Nov 20, 2023
6 of 8 checks passed
@SirGitsalot SirGitsalot deleted the update-action-versions branch November 20, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants