Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address cleanup script linter warnings #603

Merged
merged 1 commit into from
Nov 13, 2023
Merged

chore: address cleanup script linter warnings #603

merged 1 commit into from
Nov 13, 2023

Conversation

SirGitsalot
Copy link
Collaborator

The warnings were:

ERROR: Found 3 shellcheck issue(s) which need to be resolved:
ERROR: scripts/cleanup-project.sh:45:21: SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
ERROR: scripts/cleanup-project.sh:47:21: SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
ERROR: scripts/cleanup-project.sh:50:24: SC2128: Expanding an array without an index only gives the first element.

@SirGitsalot
Copy link
Collaborator Author

This fixes the "sanity-and-lint" tests. The integrations tests are still failing, those will be fixed in separate PRs.

@SirGitsalot SirGitsalot merged commit a6aa446 into master Nov 13, 2023
3 of 4 checks passed
@SirGitsalot SirGitsalot deleted the shellcheck branch November 13, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SirGitsalot @rileykarson