HBASE-22174 Remove error prone from our precommit javac check #113
Conversation
|
could we make this a CLI flag and turn it on during nightly runs? nightly doesn't do a before/after so the stability shouldn't matter. (it's also already set to be -0 instead of -1) I just think if the profile doesn't get activated in any of our automatic builds the chances of someone deciding to look at it is basically 0. |
|
Nightly will also use the hbase-personality script? Do not know that before... Then the fix will be a bit different. Let me check. |
|
🎊 +1 overall
This message was automatically generated. |
|
yeah, nightly runs up to 3 of 4 potential different yetus invocations and all of them use the personality. |
|
🎊 +1 overall
This message was automatically generated. |
|
Oh a bit strange, the merge operation will generate a merge commit... |
|
There's a different option when accepting a PR that avoids the merge commit. I guess we didn't make it the default for the repo after all? |
|
Looks like we'll need to ask infra to change it; I don't see repo settings. |
|
Yes, the default action is create a merge commit... I just clicked the button and then clicked confirm merge... |
|
If I remember correctly on hbase-connectors after I submitted a PR with "Squash and merge" the next time that became the default action for me. |
The output of the error prone check is not stable, sometimes we miss several warnings, and sometimes the order of the warnings are changed. Remove it for now. Can add back later after we fix all these problems. Or another solution is to add it back as a separated check in pre commit and add it to the filter list, so it will only generate a -0 instead of -1.