Add dependency definition for 'tf2_geometry_msgs' and 'tf2_ros' #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just tried manually build this package and noticed that some deps where missing, causing a fail at build phase. The main problem seems like
tf2_geometry_msgsbeing missing, making the build crash.But I also noticed that there are headers including
tf2_rosstuff, but no dependency is defined on it. We could get it transitively fromtf2_geometry_msgs, but the proper way would also add a dependency definition fortf2_rosOverview
Add 'tf2_geometry_msgs' and 'tf2_ros' to package manifest and also
find_packagethem at CMakeLists