Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.x support #12

Merged
merged 6 commits into from
May 5, 2024
Merged

1.5.x support #12

merged 6 commits into from
May 5, 2024

Conversation

lohanidamodar
Copy link
Member

@lohanidamodar lohanidamodar commented Apr 11, 2024

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@stnguyen90 stnguyen90 self-requested a review April 22, 2024 18:42
@stnguyen90 stnguyen90 self-requested a review April 25, 2024 13:32
.github/workflows/publish.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lohanidamodar
Copy link
Member Author

@stnguyen90 addressed your comments

README.md Outdated Show resolved Hide resolved
src/services/storage.ts Outdated Show resolved Hide resolved
@stnguyen90 stnguyen90 self-requested a review April 29, 2024 23:45
stnguyen90

This comment was marked as duplicate.

@stnguyen90 stnguyen90 self-requested a review April 29, 2024 23:46
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@lohanidamodar
Copy link
Member Author

@stnguyen90 fixed

@lohanidamodar lohanidamodar merged commit 897b6cf into main May 5, 2024
@lohanidamodar lohanidamodar deleted the dev branch May 5, 2024 05:24
@stnguyen90 stnguyen90 restored the dev branch May 17, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants