Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #124

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Small fixes #124

wants to merge 2 commits into from

Conversation

coolteemf
Copy link

Projector couldn't actually be used without specifying device as several parts of the code relied on device for sensor dimensions and source to detector distance.
Instead, Projector now use its methods source_to_detector_distance and sensor_width, sensor_height, which default to device if device is set.
Also fix a wrong variable name for the logger in image_utils.py

@benjamindkilleen
Copy link
Member

Thanks for the attention to this! However, this is the dev branch, which is always in development and subject to change. If you would like to add significant new features, please open a pull request to the main branch. You can also let us know if there's something you'd like to work on, and we'd be happy to discuss the best way to implement it.

@coolteemf
Copy link
Author

Thank you for making the wonderful tool that is DeepDRR !
I understand that my changes may not integrate into the workflow of the dev team.
I just needed to use the dev branch in order to take advantage of the new cuda-python replacement for pycuda.
However, in order to be able to run my code, I needed to add those small fixes and I thought I would share these fixes.
If my changes are not needed, it is totally okay to just close the PR.

I'll let you know if I come across a feature I'd like to add to deepdrr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants