feat(argo-cd): Add existingVolumes setting for remaining deployments with emptyDir volumes
#2456
+85
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodgit
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
|
FYI |
|
FYI: The CI is fixed now. 👍 |
bodgit
force-pushed
the
existing-volumes
branch
from
e19c4ae
to
dcc068f
Compare
|
@yu-croco Rebased and all tests now pass. |
pdrastil
reviewed
Jan 30, 2024
charts/argo-cd/templates/argocd-application-controller/statefulset.yaml
Outdated
Show resolved
Hide resolved
…s with emptyDir volumes Signed-off-by: Matt Dainty <matt@bodgit-n-scarper.com>
bodgit
force-pushed
the
existing-volumes
branch
from
dcc068f
to
d0cf96f
Compare
Signed-off-by: Matt Dainty <matt@bodgit-n-scarper.com>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Probably needs rebasing rather than closing? 🤔 |
|
Hi @bodgit , can you please fetch latest remote diff and resolve conflicts? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2410 added the
existingVolumessetting for the repo-server component. This PR adds an equivalent setting to the other Argo CD components that haveemptyDirvolumes in their deployment so you can either use a PVC or further tune theemptyDirvolume withsizeLimitparameters, etc. (which is what I do).Checklist: