Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nushell integration after nushell language change #1610

Closed
wants to merge 3 commits into from

Conversation

heiytor
Copy link

@heiytor heiytor commented Jul 31, 2023

Summary

I encountered an issue while setting up asdf in my Nushell. The error message stated that the let-env call is deprecated and should be replaced with $env.<environment variable>. I noticed that the Nushell documentation has not been updated to reflect this change. To resolve this issue, I made the necessary changes and improvements to the Nushell & Git documentation in the getting started section for both English and Brazilian users.

This pull request addresses the following:

  1. Replaces all instances of let-env with $env.PATH to fix the deprecation issue.
  2. Improved the Nushell & Git documentation to reflect the correct usage for setting environment variables. I don't have macOS or Arch, so I didn't change the respective documentation.

Fixes: #1609

Changes Made

  • Replaced all let-env calls with $env.PATH to comply with the deprecation.
    Captura de tela 2023-07-31 012713
  • Updated the Nushell & Git documentation in the getting started section for both English and Brazilian users.

Thank you for considering this pull request. I'm looking forward to your feedback!

@heiytor heiytor requested a review from a team as a code owner July 31, 2023 05:09
@hyperupcall
Copy link
Contributor

hyperupcall commented Aug 15, 2023

Thank you for starting this!

Did you run the tests locally? They contain uses of let-env as well and they also show the deprecation notices.

@heiytor
Copy link
Author

heiytor commented Aug 16, 2023

Hello.

I ended up forgetting to do the tests. I'll do another commit to resolve this, also review the semantic-pr.

@jthegedus jthegedus changed the title Fix asdf nushell support fix: nushell integration after nushell language change Sep 10, 2023
@jthegedus
Copy link
Contributor

as with #1624 this is still broken as the Nushell language has changed again.

@jthegedus
Copy link
Contributor

Closed in #1624

Thanks for raising this PR @heiytor Apologies for being AFK and not getting to merging this before yet another Nushell language change. Your contributions are appreciated despite not being merged 🙇

@jthegedus jthegedus closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Deprecated Call 'let-env' in asdf.nu
3 participants