Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Terraform configuration files #1

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

tamilver-amzn
Copy link
Contributor

Created PR initial commit for the Macie customization terraform configuration files.

@rahul-amzn rahul-amzn self-requested a review April 14, 2023 03:54
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we avoid backend config?

@@ -0,0 +1,7 @@
terraform {
backend "s3" {
bucket = "macie-customization-audit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we avoid backend / static bucket name??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above comment

@@ -0,0 +1,7 @@
terraform {
backend "s3" {
bucket = "macie-customization-bucket"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we avoid backend / static bucket name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variables cannot be used in terraform backend configuration to have dynamic bucket name. ref - hashicorp/terraform#13022

prerequisites/AUDIT/main.tf Show resolved Hide resolved
@tamilver-amzn tamilver-amzn merged commit 998163d into aws-samples:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants