Excise LocusContext class #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 95.72% 96.15% +0.43%
==========================================
Files 25 25
Lines 818 781 -37
Branches 157 153 -4
==========================================
- Hits 783 751 -32
+ Misses 18 16 -2
+ Partials 17 14 -3
Continue to review full report at Codecov.
|
standage
added a commit
that referenced
this pull request
Feb 5, 2020
The best place to put code related to panel definition/design (MicroHapDB core code, MicroHapulator core code, or ancillary code) has been a subject of frequent consideration over the last few months. See #66, #67, bioforensics/MicroHapDB#34, bioforensics/MicroHapDB#35, bioforensics/MicroHapDB#36. This update moves some of the preliminary panel design code out of the MicroHapulator core into a dedicated notebook. Various tests were updated to not rely on these panel definitions being in the MicroHapulator core code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update removes the
LocusContextclass in favor of theTargetAmpliconclass in MicroHapDB designed for the same purpose.