Handle empty inputs gracefully #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytaxonkit.py
Outdated
| assert result.TaxID.equals(pandas.Series([1082657, 265720, 1191594, 106649, 2868953])) | ||
| assert result.Code.equals(pandas.Series([1082657, 265720, 1191594, 106649, 2868953])) | ||
| assert result.Lineage.equals(pandas.Series([ | ||
| print(result) |
There was a problem hiding this comment.
I think this print statement was left here accidentally.
RyanBerger98
approved these changes
Dec 30, 2021
|
Thanks @RyanBerger98! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most taxonkit operations accept a list of input values. When the list passed to the corresponding pytaxonkit function is empty, pytaxonkit still attempts to run taxonkit, with predictably poor results. This PR updates the code to intercept these cases, emit a warning message, and exit the function before any attempt to run taxonkit.
Also included are some minor changes to expected test results that are needed on a roughly monthly basis due to updates to the NCBI Taxonomy database.
Closes #18.