Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 Adds TS/JS Support #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BenJanecke
Copy link

This seems to be enough to enable TS/JS support.
Lemme know if I missed a spot.

Copy link
Owner

@brobeson brobeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this functionality. I just have a few requests, mostly due to how VS Code's extension publication tool.

@@ -4,6 +4,11 @@

This file documents all notable changes to the VS Code Lizard extension.

## [1.0.2] — 2022-09-29
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [1.0.2] — 2022-09-29
## Unreleased

I'll update this with the correct version and release date when I cut a new release. I worry users might get confused if the change log says 1.0.2 but there isn't a v1.0.2 tag.

@@ -1,17 +1,18 @@
{
"name": "vscode-lizard",
"version": "1.0.1",
"version": "1.0.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "1.0.2",
"version": "1.0.1",

VS Code's publication tool will update this when I publish a new release.

"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "vscode-lizard",
"version": "1.0.1",
"version": "1.0.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "1.0.2",
"version": "1.0.1",

VS Code's publication tool will update this when I publish a new release.

@@ -2,7 +2,7 @@
"name": "vscode-lizard",
"displayName": "VS Code Lizard",
"description": "Run complexity analysis on your code.",
"version": "1.0.1",
"version": "1.0.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "1.0.2",
"version": "1.0.1",

VS Code's publication tool will update this when I publish a new release.

@brobeson brobeson added the enhancement New feature or request label Jun 23, 2023
@brobeson brobeson added this to the Version 1.1.0 milestone Jun 23, 2023
@brobeson brobeson linked an issue Jun 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support all the file types supported by Lizard
2 participants