Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chart): configure CP-CAS TLS flag #1020

Merged
merged 1 commit into from
Jun 24, 2024
Merged

feat(chart): configure CP-CAS TLS flag #1020

merged 1 commit into from
Jun 24, 2024

Conversation

migmartri
Copy link
Member

@migmartri migmartri commented Jun 24, 2024 •
edited
Loading

Automatically configure the CP->CAS communication to be secure if TLS settings are set in CAS.

@@ -463,7 +463,7 @@                                                   
     cas_server:                                                      
       grpc:                                                          
         addr: chainloop-2-cas-api:80
-      insecure: true                                                 
+      insecure: false                                                
       download_url: /download                                        
     plugins_dir: /plugins                                            
     referrer_shared_index:

Closes #1018

@migmartri
feat(chart): configure CP-CAS TLS flag
220a28d 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri merged commit c141736 into chainloop-dev:main Jun 24, 2024
13 checks passed
@migmartri migmartri deleted the fix-cas-connection-2 branch June 24, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javirln javirln javirln approved these changes

@jiparis jiparis Awaiting requested review from jiparis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CP-CAS communication fails when server TLS is enabled
2 participants
@migmartri @javirln