Broker parameters for anonymous TLS to leaf node #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three new parameters for choria::broker * client_anon_tls * request_signing_certificate * deny_server_connections to set each of * plugin.choria.network.client_anon_tls * plugin.choria.security.request_signing_certificate * plugin.choria.network.deny_server_connections by default there is no change to the broker.conf
ripienaar
reviewed
Apr 8, 2021
| @@ -51,6 +51,9 @@ | |||
| # @param client_hosts Whitelist of clients that are allowed to connect to broker | |||
| # @param adapters Data adapters to configure | |||
| # @param leafnode_upstreams Leafnode connections to configure | |||
| # @param client_anon_tls Use anonymous TLS for client connections (disables verification) | |||
| # @param request_signing_certificate The public certificate of the key used to sign the JWTs in the Signing Service | |||
| # @param deny_server_connections Set ACLs denying server connections to this broker | |||
There was a problem hiding this comment.
Nice, I think what we should do though - since these are pretty scary settings - is to call them out seperate with a link to the blog post detailing this model and later if we add docs to choria.io/docs covering this we can update here.
Users changing these settings will pretty much always have a bad time unless they have the context from the blog post.
There was a problem hiding this comment.
Sure put this on hold till I at least have things working ( which I don't)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three new parameters for choria::broker
to set each of
by default there is no change to the broker.conf