-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#285) support logging to stderr/stdout/discard it #286
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -48,7 +48,7 @@ | |||
Stdlib::Absolutepath $server_provisioning_token_file, | |||
Optional[String] $server_provisioning_token, | |||
Boolean $manage_server_config, | |||
Stdlib::Absolutepath $logfile, | |||
Variant[Enum['stderr', 'stdout', 'discard',], Stdlib::Absolutepath] $logfile, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer "
not '
for these, also if refernecing a commit issue it should be in this repo not cross repos, so maybe open one here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ignore comment about issue in same repo, i am blind)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor tweaks
No description provided.