Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-authored-by checking fails unexpectedly #4329

Open
2 of 17 tasks
ilrudie opened this issue May 20, 2024 · 5 comments
Open
2 of 17 tasks

Co-authored-by checking fails unexpectedly #4329

ilrudie opened this issue May 20, 2024 · 5 comments
Assignees
Labels

Comments

@ilrudie
Copy link

ilrudie commented May 20, 2024

Summary

When I accept suggestions by maintainers of the istio project it causes the easyCLA check for that commit to fail with a message:

The email address for the commit (istio/istio.io@4f5e466) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

Following the troubleshooting steps I do see both authors as valid "clickable" links to github profiles. The co-author's email address looks to be the same as his regular contributions to the project so the only thing I can figure is easyCLA isn't validating these co-authored entries correctly.

Background

Provide context to the issue - provide steps to reproduce the behavior, such as:

  1. Go to 'Ambient policy enforcement istio/istio.io#15072 (comment)' to view the error. I will try to leave it up for a while but we do need to move the PR along at some point.

This was created by:

  1. Submitted a PR to istio/istio.io repo
  2. Receive and accept suggestions from a maintainer of the repository using the github PR web ui.

Expected behavior

I would expect suggestions from maintainers who have signed the CLA would not trigger a failure when their email becomes associated with the commit by addition of a "Co-authored-by" line in the commit message.

Screenshots

image

Environment

Please complete the following information:

  • Environment:
    • ALL
    • DEV
    • STAGING
    • PROD
    • CI
  • Browser:
    • Chrome/Brave
    • Firefox
    • Opera
    • Vivaldi
    • LibreWolf
    • SRware Iron
    • Dissenter
    • Slimjet
    • Midori
    • Edge
    • Lynx
    • Safari
@ilrudie ilrudie added the bug Something isn't working label May 20, 2024
@svrnm
Copy link

svrnm commented May 22, 2024

@jarias-lfx
Copy link

jarias-lfx commented May 22, 2024

Update:
We have identified the root cause of the issue and decided to rollback the co-author changes to unblock the community, since the fix will take longer engineering time. The PR should update by adding /easycla comment, which I added the in the reported PRs and confirmed EasyCLA passing.
Thank you for your patience.

@svrnm
Copy link

svrnm commented May 22, 2024

thanks @jarias-lfx

@ilrudie
Copy link
Author

ilrudie commented May 22, 2024

Thanks @jarias-lfx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants