Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Localization inconsistencies of contents of "Running in multiple zones" #46240

Merged
merged 10 commits into from
Jul 3, 2024

Conversation

EigoOda
Copy link
Contributor

@EigoOda EigoOda commented May 7, 2024

Closes: #41865

@EigoOda EigoOda marked this pull request as draft May 7, 2024 08:39
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 7, 2024
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label May 7, 2024
@k8s-ci-robot k8s-ci-robot requested a review from t-inu May 7, 2024 08:39
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label May 7, 2024
Copy link

netlify bot commented May 7, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d888dac
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66849cbf2f92f8000824d812
😎 Deploy Preview https://deploy-preview-46240--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@inductor inductor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

短くするならこうですかね

content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
Co-authored-by: Kohei Ota (inductor) <kela@inductor.me>
Copy link

linux-foundation-easycla bot commented May 20, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 20, 2024
@inductor
Copy link
Member

/easycla

@Okabe-Junya
Copy link
Member

(ちゃんと原因把握していないんですけど、suggestion経由でcommitすると、最近往々にして発生しますよね。。)


結果は以下のようになります:
ノードが起動すると、各ノードのkubeletは、Kubernetes APIで特定のkubeletを表すノードオブジェクトに{{< glossary_tooltip text="ラベル" term_id="label" >}}を自動的に追加します。これらのラベルには[ゾーン情報](/docs/reference/labels-annotations-taints/#topologykubernetesiozone)を含めることができます。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ゾーン情報のリンクは、ja がなかったので、en のページをリンクしました

```shell
LoadBalancer Ingress: 130.211.126.21
```
クラスターが複数のゾーンまたはリージョンにまたがっている場合、ノードラベルと[Pod Topology Spread Constraints](/docs/concepts/scheduling-eviction/topology-spread-constraints/)を組み合わせて使用することで、リージョン、ゾーン、さらには特定のノードといった障害ドメイン間でクラスター全体にPodをどのように分散させるかを制御できます。これらのヒントにより、{{< glossary_tooltip text="スケジューラー" term_id="kube-scheduler" >}}は予想される可用性を高めてPodを配置し、相関する障害がワークロード全体に影響するリスクを低減できます。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pod Topology Spread Constraints のリンクも、ja がなかったので、en のページをリンクしました

content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
@EigoOda EigoOda marked this pull request as ready for review May 22, 2024 07:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@EigoOda
Copy link
Contributor Author

EigoOda commented May 22, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2024
@Okabe-Junya
Copy link
Member

Okabe-Junya commented May 23, 2024

大元の変更でco-author commitの挙動にバグが入っていたらしく、昨日無事??解決したっぽいですね(なのでこのままで大丈夫です🙆‍♂️お騒がせしました)

communitybridge/easycla#4329 (comment)

@EigoOda
Copy link
Contributor Author

EigoOda commented May 23, 2024

@Okabe-Junya
ご確認、ご対応ありがとうございます🙏

@inductor
Copy link
Member

ワイがなんかやらかしたのかと思って焦った

@Okabe-Junya
Copy link
Member

レビューできておらず申し訳ないです。。

@t-inu @atoato88 @kakts

すでにレビューされていらっしゃる方いますか?いなさそうであれば、自分の方でレビューさせて頂きます

@Okabe-Junya
Copy link
Member

/assign

Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューが遅くなって申し訳ありません。何点かコメントしたのでご確認お願いします!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just note) 主に https://github.com/kubernetes/website/pull/23498/files の変更の取り込みのため、削除部分が多い

content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
content/ja/docs/setup/best-practices/multiple-zones.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 28, 2024
@EigoOda
Copy link
Contributor Author

EigoOda commented Jun 28, 2024

@Okabe-Junya @t-inu @nasa9084
レビューありがとうございます!
修正が遅くなりすみません。
コメントいただいた箇所を修正しましたので、再度レビューいただければと思います🙏

Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます!LGTMです!

/lgtm

Deploy preview: link

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73360c3c4462b494f11ce3a99e1f0b402a8ba057

@Okabe-Junya
Copy link
Member

/assign nasa9084
for approval

@inductor
Copy link
Member

inductor commented Jul 1, 2024

これが気になる

#46240 (comment)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2024
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73ebefdec95e7b489e39dca173b28bc3c9cfa04d

@inductor
Copy link
Member

inductor commented Jul 3, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor, Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit eb2e79a into kubernetes:main Jul 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Localization inconsistencies of contents of "Running in multiple zones"
6 participants