-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
searches all branches when tag filter is provided and branch isn't #225
Conversation
Signed-off-by: Richard Godden <goddenrich@gmail.com>
@goddenrich Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@goddenrich Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviving this! Happy to merge it for now even though spaces is on the horizon (and with it we may begin phasing this resource out in favor of separate ones for narrower workflows, e.g. tag-based vs. commit-based).
…to tags-across-all-branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, didn't see you had pushed a merge, sorry for the delay!
This looks good to me. I can merge this soon, just checking in to make sure it's ready since it's been a while since the last update (my fault).
Feel free to merge its good on my end |
@goddenrich thanks! |
Has this been released yet? If so, what version has this fix? |
@lancempoe v1.1 judging by the commit's tags in the GitHub UI: 57614ae Sorry that's not super discoverable. The release process for our core resource types is kind of in flux right now and we don't have a great workflow for release notes yet (managing all these core resource types is a lot of work). |
This has been attempted before In #176 and #165. I think this works now. I know this may be made obsolete by spaces but Im not sure when this will land and we have a need for this behaviour now.
Signed-off-by: Richard Godden goddenrich@gmail.com