Adopt Helm chart to mimic Amazon EKS CoreDNS naming conventions #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youwalther65
commented
Feb 22, 2023
youwalther65
commented
- modified Helm chart to mimic Amazon EKS CoreDNS deployment
- minor changes due to PDB
- modified values.yaml resources to not contain hyphen in name because this is not supported for Helm
- added pdb.name because it does not fit intp podDisruptionBudget resource
- removed critical-pod annotation because it is already invalid
- final commit before submitting PR
|
See also my feature request here |
Signed-off-by: Jens-Uwe Walther <waltju@amazon.com>
Signed-off-by: Jens-Uwe Walther <waltju@amazon.com>
…this is not supported for Helm Signed-off-by: Jens-Uwe Walther <waltju@amazon.com>
Signed-off-by: Jens-Uwe Walther <waltju@amazon.com>
Signed-off-by: Jens-Uwe Walther <waltju@amazon.com>
Signed-off-by: Jens-Uwe Walther <waltju@amazon.com>
|
cc @mrueg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.