Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix static binaries failed on macOS from version 15~18 #28

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Jun 4, 2024

closes #26

@shenxianpeng shenxianpeng marked this pull request as ready for review June 4, 2024 16:57
@shenxianpeng shenxianpeng added the bug Something isn't working label Jun 4, 2024
@shenxianpeng shenxianpeng changed the title create link for lib zstd when version >14 on macos fix static binaries failed on macOS from version 14~18 Jun 5, 2024
Copy link
Contributor Author

@shenxianpeng shenxianpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow 🤩 it works @2bndy5 👍

@shenxianpeng shenxianpeng self-assigned this Jun 5, 2024
@shenxianpeng shenxianpeng requested a review from 2bndy5 June 5, 2024 12:50
@2bndy5
Copy link

2bndy5 commented Jun 5, 2024

Well, I can see that it builds successfully. But does the CI also dry-run the executables (with say <tool-name> --version)?

Copy link

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be honest: Sometimes I surprise myself. I didn't think this would be the only solution needed. I was half expecting another problem to surface after we squashed the libzstd problem... 🤞🏼


I see that the test CI only works with latest release. Looks like we'll have to merge and publish a release with these changes. Then we can run the test CI. If that all works out then clang-tools-pip should be updated to use the new release.

@shenxianpeng
Copy link
Contributor Author

shenxianpeng commented Jun 6, 2024

Well, I can see that it builds successfully. But does the CI also dry-run the executables (with say --version)?

It's a good idea to test executables in the build CI to check it before merging or publishing. I'll add the test to build CI in the next pull request.

@shenxianpeng shenxianpeng merged commit 2e4f8c1 into master Jun 6, 2024
75 of 79 checks passed
@shenxianpeng shenxianpeng deleted the shenxianpeng/static-binaries-failed-26 branch June 6, 2024 02:07
@shenxianpeng shenxianpeng changed the title fix static binaries failed on macOS from version 14~18 fix static binaries failed on macOS from version 15~18 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static binaries failed on macOS from version 15~18
2 participants