build(jar): add datahub-custom-plugin-lib to jar workflow #10812
Conversation
github-actions
bot
added
the
devops
WalkthroughThe recent update integrates two new jobs into the Changes
Poem
Tip Early access features
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/publish-datahub-jars.yml (1 hunks)
Additional context used
GitHub Check: actionlint
.github/workflows/publish-datahub-jars.yml
[failure] 29-29:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:48: Double quote to prevent globbing and word splitting [shellcheck]Raw Output:
.github/workflows/publish-datahub-jars.yml:29:9: shellcheck reported issue in this script: SC2086:info:2:48: Double quote to prevent globbing and word splitting [shellcheck]
[failure] 42-42:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2001:style:2:7: See if you can use ${variable//search/replace} instead [shellcheck]Raw Output:
.github/workflows/publish-datahub-jars.yml:42:9: shellcheck reported issue in this script: SC2001:style:2:7: See if you can use ${variable//search/replace} instead [shellcheck]
[failure] 42-42:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:12: Double quote to prevent globbing and word splitting [shellcheck]Raw Output:
.github/workflows/publish-datahub-jars.yml:42:9: shellcheck reported issue in this script: SC2086:info:2:12: Double quote to prevent globbing and word splitting [shellcheck]
[failure] 42-42:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:20: Double quote to prevent globbing and word splitting [shellcheck]Raw Output:
.github/workflows/publish-datahub-jars.yml:42:9: shellcheck reported issue in this script: SC2086:info:3:20: Double quote to prevent globbing and word splitting [shellcheck]
[failure] 75-75:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]Raw Output:
.github/workflows/publish-datahub-jars.yml:75:9: shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[failure] 88-88:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]Raw Output:
.github/workflows/publish-datahub-jars.yml:88:9: shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[failure] 101-101:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]Raw Output:
.github/workflows/publish-datahub-jars.yml:101:9: shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[failure] 114-114:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]Raw Output:
.github/workflows/publish-datahub-jars.yml:114:9: shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[failure] 127-127:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]Raw Output:
.github/workflows/publish-datahub-jars.yml:127:9: shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
| - name: publish datahub-custom-plugin-lib snapshot jar | ||
| if: ${{ github.event_name != 'release' }} | ||
| env: | ||
| RELEASE_USERNAME: ${{ secrets.RELEASE_USERNAME }} | ||
| RELEASE_PASSWORD: ${{ secrets.RELEASE_PASSWORD }} | ||
| SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }} | ||
| SIGNING_KEY: ${{ secrets.SIGNING_KEY }} | ||
| NEXUS_USERNAME: ${{ secrets.NEXUS_USERNAME }} | ||
| NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }} | ||
| run: | | ||
| echo signingKey=$SIGNING_KEY >> gradle.properties | ||
| ./gradlew :metadata-integration:java:custom-plugin-lib:printVersion | ||
| ./gradlew :metadata-integration:java:custom-plugin-lib:publish |
There was a problem hiding this comment.
Add Double Quotes to Prevent Globbing and Word Splitting
The shell commands should be updated to include double quotes to prevent globbing and word splitting.
- echo signingKey=$SIGNING_KEY >> gradle.properties
+ echo "signingKey=$SIGNING_KEY" >> gradle.propertiesCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: publish datahub-custom-plugin-lib snapshot jar | |
| if: ${{ github.event_name != 'release' }} | |
| env: | |
| RELEASE_USERNAME: ${{ secrets.RELEASE_USERNAME }} | |
| RELEASE_PASSWORD: ${{ secrets.RELEASE_PASSWORD }} | |
| SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }} | |
| SIGNING_KEY: ${{ secrets.SIGNING_KEY }} | |
| NEXUS_USERNAME: ${{ secrets.NEXUS_USERNAME }} | |
| NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }} | |
| run: | | |
| echo signingKey=$SIGNING_KEY >> gradle.properties | |
| ./gradlew :metadata-integration:java:custom-plugin-lib:printVersion | |
| ./gradlew :metadata-integration:java:custom-plugin-lib:publish | |
| - name: publish datahub-custom-plugin-lib snapshot jar | |
| if: ${{ github.event_name != 'release' }} | |
| env: | |
| RELEASE_USERNAME: ${{ secrets.RELEASE_USERNAME }} | |
| RELEASE_PASSWORD: ${{ secrets.RELEASE_PASSWORD }} | |
| SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }} | |
| SIGNING_KEY: ${{ secrets.SIGNING_KEY }} | |
| NEXUS_USERNAME: ${{ secrets.NEXUS_USERNAME }} | |
| NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }} | |
| run: | | |
| echo "signingKey=$SIGNING_KEY" >> gradle.properties | |
| ./gradlew :metadata-integration:java:custom-plugin-lib:printVersion | |
| ./gradlew :metadata-integration:java:custom-plugin-lib:publish |
| - name: release datahub-custom-plugin-lib jar | ||
| if: ${{ github.event_name == 'release' }} | ||
| env: | ||
| RELEASE_USERNAME: ${{ secrets.RELEASE_USERNAME }} | ||
| RELEASE_PASSWORD: ${{ secrets.RELEASE_PASSWORD }} | ||
| SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }} | ||
| SIGNING_KEY: ${{ secrets.SIGNING_KEY }} | ||
| NEXUS_USERNAME: ${{ secrets.NEXUS_USERNAME }} | ||
| NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }} | ||
| run: | | ||
| echo signingKey=$SIGNING_KEY >> gradle.properties | ||
| ./gradlew -PreleaseVersion=${{ needs.setup.outputs.tag }} :metadata-integration:java:custom-plugin-lib:publish | ||
| ./gradlew :metadata-integration:java:custom-plugin-lib:closeAndReleaseRepository --info |
There was a problem hiding this comment.
Add Double Quotes to Prevent Globbing and Word Splitting
The shell commands should be updated to include double quotes to prevent globbing and word splitting.
- echo signingKey=$SIGNING_KEY >> gradle.properties
+ echo "signingKey=$SIGNING_KEY" >> gradle.propertiesCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: release datahub-custom-plugin-lib jar | |
| if: ${{ github.event_name == 'release' }} | |
| env: | |
| RELEASE_USERNAME: ${{ secrets.RELEASE_USERNAME }} | |
| RELEASE_PASSWORD: ${{ secrets.RELEASE_PASSWORD }} | |
| SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }} | |
| SIGNING_KEY: ${{ secrets.SIGNING_KEY }} | |
| NEXUS_USERNAME: ${{ secrets.NEXUS_USERNAME }} | |
| NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }} | |
| run: | | |
| echo signingKey=$SIGNING_KEY >> gradle.properties | |
| ./gradlew -PreleaseVersion=${{ needs.setup.outputs.tag }} :metadata-integration:java:custom-plugin-lib:publish | |
| ./gradlew :metadata-integration:java:custom-plugin-lib:closeAndReleaseRepository --info | |
| - name: release datahub-custom-plugin-lib jar | |
| if: ${{ github.event_name == 'release' }} | |
| env: | |
| RELEASE_USERNAME: ${{ secrets.RELEASE_USERNAME }} | |
| RELEASE_PASSWORD: ${{ secrets.RELEASE_PASSWORD }} | |
| SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }} | |
| SIGNING_KEY: ${{ secrets.SIGNING_KEY }} | |
| NEXUS_USERNAME: ${{ secrets.NEXUS_USERNAME }} | |
| NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }} | |
| run: | | |
| echo "signingKey=$SIGNING_KEY" >> gradle.properties | |
| ./gradlew -PreleaseVersion=${{ needs.setup.outputs.tag }} :metadata-integration:java:custom-plugin-lib:publish | |
| ./gradlew :metadata-integration:java:custom-plugin-lib:closeAndReleaseRepository --info |
Checklist
Summary by CodeRabbit