Test Apis Workflow #480
Open
Test Apis Workflow #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pranavv0
commented
May 1, 2023
•
pranavv0
commented
- Workflow for Test Automation
- Script of Pytest
- Dockerfile
|
Can one of the admins verify this patch? |
abhi4578
requested changes
May 3, 2023
abhi4578
reviewed
May 11, 2023
abhi4578
requested changes
May 23, 2023
| "username": "<rmq user>", | ||
| "password": "<rmq password>", | ||
| "host": "<rmq host>", | ||
| "port": "<rmq amq port>", | ||
| "hport": "<rmq https port>", | ||
| "hport": "<rmq https port, required only if createVhost is true >", |
There was a problem hiding this comment.
use proper config fields, should be clear by just reading it
- use
httpsPortinstead ofhport - use
amqpsPortinstead ofport--> also its better to connect and test over amqps .
| response = requests.put(url, auth=(username, password)) | ||
| if createVhost: | ||
| url = f'https://{host}:{hport}/api/vhosts/{vhost}' | ||
| response = requests.put(url, auth=(username, password)) | ||
|
|
||
| # rabbitmq amqp connection details | ||
| connection = pika.BlockingConnection( | ||
| pika.URLParameters(f'amqp://{username}:{password}@{host}:{port}/{vhost}')) |
There was a problem hiding this comment.
its better to connect and test over amqps
| @@ -1,9 +1,10 @@ | |||
| { | |||
| "createVhost" : "True or False, if vhost is required to create", | |||
There was a problem hiding this comment.
should n't the True or False be without the quotes
|
Also update readme of the test. There is only one test now for lip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.