-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node bump #223
Conversation
@line-o mind taking a look and merging? |
The version has to be 4.0.0-snapshot as the processor version must be 6.1.0 because of slf4japi version is now v2 |
See my open PR |
bump version and exist core depdendency BREAKING CHANGES: Bumps required exist version to development version see #210
@line-o ok I see, however, the changes to slf4japi are unrelated to the changes in this PR. The version bump should have been made with those earlier PRs. If we bump the processor dependency now, without a published jar file, we can no longer compile monex, or create releases from the main branch. Which leaves us two options:
I don't really care which way, having a security release would probably be nicest for users. I have no idea where I can find the |
close #222
bumps node to
18
, lots of vulnerability fixes, more could be done, but I think this is fit for a maintenance release. Could be a major release, as we are deprecating older versions of node during build time.P.S.: once this is merged we should check #215