feat: implements revocation in DataPlaneAuthorizationService #4019
Conversation
wolf4ood
force-pushed
the
feat/3997_terminate_mesage
branch
2 times, most recently
from
2779aa6
to
2eddb30
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...i/src/main/java/org/eclipse/edc/connector/dataplane/spi/iam/DataPlaneAccessTokenService.java
Fixed
Show fixed
Hide fixed
wolf4ood
force-pushed
the
feat/3997_terminate_mesage
branch
from
2eddb30
to
4cfcaec
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4019 +/- ##
==========================================
+ Coverage 71.74% 73.63% +1.88%
==========================================
Files 919 984 +65
Lines 18457 19896 +1439
Branches 1037 1119 +82
==========================================
+ Hits 13242 14650 +1408
- Misses 4756 4771 +15
- Partials 459 475 +16 ☔ View full report in Codecov by Sentry. |
wolf4ood
force-pushed
the
feat/3997_terminate_mesage
branch
2 times, most recently
from
3ac573f
to
029c883
Compare
wolf4ood
force-pushed
the
feat/3997_terminate_mesage
branch
from
029c883
to
4a3596a
Compare
| * @param reason The reason for the revocation | ||
| * @return Success if revoked, failure otherwise | ||
| */ | ||
| Result<Void> revoke(String transferProcessId, String reason); |
Check notice
Code scanning / CodeQL
Useless parameter Note
wolf4ood
force-pushed
the
feat/3997_terminate_mesage
branch
from
4a3596a
to
f5e48ec
Compare
| * @param reason The reason for the revocation | ||
| * @return Success if revoked, failure otherwise | ||
| */ | ||
| Result<Void> revoke(String transferProcessId, String reason); |
There was a problem hiding this comment.
is the reason needed here? It makes sense in the TransferProcess context because the counter part then knows why, but I'm not sure the data plane needs to know. In fact in the implementation is not used
There was a problem hiding this comment.
For our internal impl we don't use it, but that might be useful for other impl? that's why i left it
What this PR changes/adds
implements revocation in DataPlaneAuthorizationService
Why it does that
Notify the
DataPlaneAuthorizationServicethat the transfer has been terminated or suspendedFurther notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #3997
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.