Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move interface to SPI #4102

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

moves the CredentialServiceUrlResolver to the SPI package, where it belongs.

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Apr 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.68%. Comparing base (7f20ba5) to head (37aa66c).
Report is 204 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4102      +/-   ##
==========================================
+ Coverage   71.74%   74.68%   +2.94%     
==========================================
  Files         919      979      +60     
  Lines       18457    20088    +1631     
  Branches     1037     1131      +94     
==========================================
+ Hits        13242    15003    +1761     
+ Misses       4756     4591     -165     
- Partials      459      494      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 1ee5974 into eclipse-edc:main Apr 9, 2024
18 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/move_interface_to_spi branch April 9, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants