contribution: Jonboulle nell add aws region #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @dapollak |
When initialising a [Boto3 `Session`](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/session.html#session-configurations) it's useful to be able to specify the AWS Region to which the client should connect. Add an `--aws-region-name` option to the CLI which gets passed through to the `boto3` client used by the S3 client. Context: We're trying to use elementary to write to a Cloudflare R2 bucket, which implements the S3 API. However, the S3 endpoints for these buckets do not encode the region, and hence the `--s3-endpoint-url` flag isn't sufficient to be able to configure elementary to successfully access the buckets. Without this flag, it means we need write an AWS Profile configuration to disk and pass that in to elementary in order to override the region, which isn't desirable in contexts where we integrate elementary (e.g. invoking it from Airflow).
dapollak
force-pushed
the
jonboulle-nell-add-aws-region
branch
from
83a8099
to
6c387d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.