ELE-2241 - add tags to report test results #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @IDoneShaveIt |
NoyaArie
approved these changes
Dec 26, 2023
| @@ -25,9 +25,11 @@ class TestResultDBRowSchema(ExtendedBaseModel): | |||
| test_results_description: Optional[str] | |||
| owners: Optional[List[str]] | |||
| model_owner: Optional[List[str]] | |||
| tags: Optional[List[str]] | |||
| tags: List[str] = Field(default_factory=list) | |||
There was a problem hiding this comment.
do we still need this one?
There was a problem hiding this comment.
Well there is other place that uses it and this is the combination of model tags and test_tags.
I guess I will make it a property that return the union of the 2 🙂
| @@ -62,6 +62,7 @@ class TestMetadataSchema(BaseModel): | |||
| description: Optional[str] = None | |||
| result: dict | |||
| configuration: dict | |||
| test_tags: List[str] = Field(default_factory=list) | |||
There was a problem hiding this comment.
maybe we should add this to SourceFreshnessMetadataSchema as well (just empty always). just because we are planning to use this field for all items in the table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.