-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ele 2237 new filter schema #1341
Conversation
👋 @NoyaArie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Left one small pydantic comment 🙂
selector: Optional[str] = None | ||
invocation_id: Optional[str] = None | ||
invocation_time: Optional[str] = None | ||
invocation_time: Optional[str] = Field(default=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the default field is not mutable so you can just use None 🙂
The Field default factory is for dynamic defaults and mutable defaults like list and dict
invocation_time: Optional[str] = Field(default=None) | |
invocation_time: Optional[str] = None |
No description provided.