Added singular tests to groups API. #1372
Conversation
|
👋 @elongl |
| from elementary.utils.schema import ExtendedBaseModel | ||
| from elementary.utils.time import convert_partial_iso_format_to_full_iso_format | ||
|
|
||
|
|
||
| class NormalizedTestSchema(NormalizedArtifactSchema): |
There was a problem hiding this comment.
I dislike how this is here while all the others (model, source, exposure) are at fetchers/models/schema.py even though they don't store models.
There was a problem hiding this comment.
Yeah not a fan of that either, if you wish to refactor I'm not against (but if you don't wish to refactor I'm also not against)
| from elementary.utils.schema import ExtendedBaseModel | ||
| from elementary.utils.time import convert_partial_iso_format_to_full_iso_format | ||
|
|
||
|
|
||
| class NormalizedTestSchema(NormalizedArtifactSchema): |
There was a problem hiding this comment.
Yeah not a fan of that either, if you wish to refactor I'm not against (but if you don't wish to refactor I'm also not against)
| @@ -21,7 +21,7 @@ class NormalizedArtifactSchema(ExtendedBaseModel): | |||
| # Currently, it's model_name to match the CLI UI. | |||
| model_name: str | |||
| normalized_full_path: str | |||
| fqn: str | |||
| fqn: Optional[str] = None | |||
There was a problem hiding this comment.
I'm not sure if the FE actually relies on this field existing, worth double-checking
There was a problem hiding this comment.
It's used in catalog, and lineage's bottom drawer.
Tests don't appear in either of those so that's fine.
elongl
force-pushed
the
ele-2361-show-singular-tests-in-report
branch
from
ff44ed6
to
166ab16
Compare
elongl
force-pushed
the
ele-2361-show-singular-tests-in-report
branch
from
8a5b698
to
5c7d93c
Compare
No description provided.