ELE-2398 - move sort_alerts from API to data monitoring alerts flow #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
馃憢 @IDoneShaveIt |
IDoneShaveIt
commented
Jan 24, 2024
| ) | ||
|
|
||
| def _sort_alerts( |
There was a problem hiding this comment.
Same code as it was on the alerts API
IDoneShaveIt
commented
Jan 24, 2024
| alerts_to_send.append(valid_alert) | ||
| return SortedAlertsSchema(send=alerts_to_send, skip=alerts_to_skip) | ||
|
|
||
| def _get_suppressed_alerts( |
There was a problem hiding this comment.
Same code as it was on the alerts API
IDoneShaveIt
commented
Jan 24, 2024
| return suppressed_alerts | ||
|
|
||
| @staticmethod | ||
| def _get_latest_alerts( |
There was a problem hiding this comment.
Same code as it was on the alerts API
NoyaArie
approved these changes
Jan 25, 2024
Comment on lines
+83
to
94
| def _fetch_data(self, days_back: int) -> List[PendingAlertSchema]: | ||
| return self.alerts_api.get_new_alerts( | ||
| days_back=days_back, | ||
| ) | ||
|
|
||
| def _filter_data(self, data: SortedAlertsSchema) -> SortedAlertsSchema: | ||
| return SortedAlertsSchema( | ||
| send=filter_alerts(alerts=data.send, alerts_filter=self.selector_filter), | ||
| skip=filter_alerts(alerts=data.skip, alerts_filter=self.selector_filter), | ||
| def _filter_data(self, data: List[PendingAlertSchema]) -> List[PendingAlertSchema]: | ||
| return filter_alerts(data, alerts_filter=self.selector_filter) | ||
|
|
||
| def _fetch_last_sent_times(self, days_back: int) -> Dict[str, datetime]: | ||
| return self.alerts_api.get_alerts_last_sent_times( | ||
| days_back=days_back, | ||
| ) |
There was a problem hiding this comment.
not sure we really need these functions
| if isinstance(alert.data, TestAlertDataSchema) | ||
| ] | ||
| ) == [ | ||
| "alert_id_1", |
There was a problem hiding this comment.
maybe we should change the IDs, so we won't have the same id on a different alert type.
This way we could be sure that we are not mixing between alerts types as well
IDoneShaveIt
deleted the
ele-2398-move-sort_alerts-from-api-to-data-monitoring-alerts-flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this change is that the alerts API should not be aware of the monitoring logic for filtering / skipping alerts.
This makes much more sense + it will help the SaaS alerts be more aligned with the OSS alerts code 馃檪
The main changes here is moving code from the alerts API to the DataMonitoringAlerts flow and updating tests.