Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid variable names in error messages #2883

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

ptitzler
Copy link
Member

Replace incorrect variable names in two error messages related to object storage authentication processing. AWS_IAM_ROLES_FOR_SERVICE_ACCOUNTS is an internal Elyra identifier, whereas AWS_WEB_IDENTITY_TOKEN_FILE is the variable name that should have been reported as problematic.

What changes were proposed in this pull request?

See above.

How was this pull request tested?

  • No functional change.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added the kind:bug Something isn't working label Aug 15, 2022
@ptitzler ptitzler added this to the 3.11.0 milestone Aug 15, 2022
@elyra-bot
Copy link

elyra-bot bot commented Aug 15, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akchinSTC akchinSTC merged commit 960a062 into elyra-ai:main Aug 15, 2022
@ptitzler ptitzler deleted the fix-aws-cos-auth-messages branch August 16, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants