Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github workflows to use v3/v4 actions #3095

Merged
merged 5 commits into from
Jan 31, 2023

Conversation

akchinSTC
Copy link
Member

@akchinSTC akchinSTC commented Jan 30, 2023

Signed-off-by: Alan Chin akchin@us.ibm.com

Outdated workflow actions are triggering deprecation warnings in our github action CI results

image

image

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Alan Chin <akchin@us.ibm.com>
@akchinSTC akchinSTC added the component:build build and build related issues(dependencies and docker) label Jan 30, 2023
Signed-off-by: Alan Chin <akchin@us.ibm.com>
@ptitzler
Copy link
Member

Signed-off-by: Alan Chin <akchin@us.ibm.com>
Signed-off-by: Alan Chin <akchin@us.ibm.com>
@akchinSTC akchinSTC changed the title Update github workflows to use v3 actions Update github workflows to use v3/v4 actions Jan 30, 2023
@kevin-bates
Copy link
Member

@akchinSTC - does this provide any benefit other than being on the latest action versions? I'm just curious about what the impetus was for this.

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Confirmed that the github actions no longer trigger deprecation warnings.

@akchinSTC
Copy link
Member Author

akchinSTC commented Jan 30, 2023

@akchinSTC - does this provide any benefit other than being on the latest action versions? I'm just curious about what the impetus was for this.

@kevin-bates - Updated the description with screenshots. In short, outdated actions were triggering deprecation warnings.

Signed-off-by: Alan Chin <akchin@us.ibm.com>
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akchinSTC. I also like the cron update.

@akchinSTC akchinSTC merged commit cc1cdcf into elyra-ai:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants