-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Elyra extensions to support JupyterLab 4.x #3201
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming the build failures are a temporary hurdle. Thanks for dealing with the @lresende!
af4a4de
to
ab95e71
Compare
Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
a5b1686
to
6410a77
Compare
I have made some progress here, but I would appreciate if I could get some help on the UI pieces, in particular on UI-components... @marthacryan @karlaspuldaro @ajbozarth and others feel free to send prs to this branch as time permits... I completely understand if you are not able to. |
110767d
to
7567988
Compare
Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
7567988
to
95332e5
Compare
@@ -41,7 +41,12 @@ jobs: | |||
/home/runner/.cache/Cypress | |||
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | |||
- name: Install | |||
run: yarn install --frozen-lockfile && tsc -v | |||
run: | | |||
corepack prepare yarn@3.5.0 --activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is causing build failure, maybe it's best to use a stable version of yarn
hello! is this pull request still being worked on? it would be amazing to have support for JL4 now that JL3 has an official sunset date. Is there any support required from the community? Thank you! |
There is a pr against this pr, let me merge that over the weekend and then others can jump in to help finish any remaining items |
thanks for the quick response! |
What changes were proposed in this pull request?
Migrate Elyra extensions to support JupyterLab 4.x
Fixes #3137
How was this pull request tested?
Building and running on JupyterLab 4.x
Developer's Certificate of Origin 1.1