-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump version of nbconvert #3214
base: main
Are you sure you want to change the base?
Conversation
@rkpattnaik780 could you please sign your commit? |
Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>
a278231
to
4902692
Compare
Done. The checks are also passing now! |
@lresende this also fixes #3228 Change looks good to me and I can confirm this works with Jupyterlab less than 4. @rkpattnaik780 I see you are also involved at https://github.com/opendatahub-io/notebooks/blob/main/runtimes/minimal/ubi9-python-3.9/utils/requirements-elyra.txt Can you also add the new nbconvert version to requirements-elyra, please? Thank you. |
@@ -32,7 +32,7 @@ dependencies = [ | |||
"MarkupSafe>=2.1", | |||
"minio>=7.0.0,!=7.2.1", | |||
"nbclient>=0.5.1", | |||
"nbconvert>=6.5.1", | |||
"nbconvert==7.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine, yes.
Should also be added to https://github.com/elyra-ai/elyra/blob/main/etc/generic/requirements-elyra.txt#L11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshad16 I basically said, it absolutely makes sense to update the version of nbconvert in two places simultaneously.
Bump version of
nbconvert
to fix the CVE issues introduced bymistune@2.0.3
.What changes were proposed in this pull request?
How was this pull request tested?
Developer's Certificate of Origin 1.1