Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAJOR VERSION] Move node v8 support to ES5 imports #1142

Merged
merged 5 commits into from
Jun 2, 2020

Conversation

alubbe
Copy link
Member

@alubbe alubbe commented Feb 21, 2020

This PR drops support for nodejs v8 and bumps the version to 4.0.0
v8 has been unsupported for almost 2 months now and we can use the major version change to start using node v10+ features like async iteration - what do you think?

@Siemienik
Copy link
Member

Siemienik commented Mar 22, 2020

hmm, that true

but, a lot of our users still uses node v8 - we should think about how to care about them :)
or give some months to adapting their environments

@alubbe alubbe changed the title Drop support for nodejs v8 Move node v8 support to ES5 imports Mar 25, 2020
@alubbe
Copy link
Member Author

alubbe commented Mar 25, 2020

Okay let's try a totally different approach then :)
I propose to move node v8 support to ES5 imports - users of the old version will get a clear message of what they need to change and everyone on node v10 and newer will get the full power and speed of newer features such as async iteration.

This is strictly speaking a semver-incompatible change, but I think the upgrade path is simple enough - what do you think?

@alubbe
Copy link
Member Author

alubbe commented Mar 25, 2020

@guyonroche what's your take on supporting outdated versions of node? How often would you like to release a new major version of exceljs?

@alubbe
Copy link
Member Author

alubbe commented Mar 27, 2020

I've also restored testing v8 on travis, so now that node v8 is a first class citizen as it is right now and the only breaking change is that users of node v8 will get a message to change their require statement. Can we merge that and publish it as 4.0.0 @guyonroche ? Then I can finish my work on async iteration and stream cancellation

@Siemienik
Copy link
Member

We have to publish v3.8.3 from current master first - 3.8.2 has bug inside - #1179 #1180 #1178

@Siemienik Siemienik changed the title Move node v8 support to ES5 imports WIP: Move node v8 support to ES5 imports Mar 30, 2020
@Siemienik
Copy link
Member

WIP because, 3.8.2 doesn't work now, we have to publish 3.8.3 version before v4.

@alubbe alubbe changed the title WIP: Move node v8 support to ES5 imports [MAJOR VERSION] Move node v8 support to ES5 imports Apr 2, 2020
@alubbe
Copy link
Member Author

alubbe commented Apr 27, 2020

I've resolved all merge conflicts and have added testing for node 14

@alubbe alubbe merged commit a81830b into exceljs:master Jun 2, 2020
@alubbe alubbe deleted the drop-v8 branch June 2, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants